Unvanquished Development activity

Events from:

Unvanquished
Unvanquished
Tuesday, 24 October 2017
@illwieckz
illwieckz pushed to master in Unvanquished/pluto-devfeeds
Oct 24, 2017
@DolceTriade
DolceTriade pushed to name_char_limit in Unvanquished/Unvanquished
  • @DolceTriade fb304e8
    scoreboard: Respect overflow rules.
Oct 24, 2017
@DolceTriade
DolceTriade opened a pull request in Unvanquished/Unvanquished
Oct 24, 2017
sgame: Limit the number of visible characters in a name to 32. #1037

Note, that the since each character can be up to 4 bytes, we make sure the underlying buffer can hold 128 chars. This ensures that people can't hav…

+9 -0
@illwieckz
Oct 24, 2017

I think it's very ok to have a view-only scoreboard, that's why truncating usernames sounds good enough to me. We can be free to make more complex …

@illwieckz
Oct 24, 2017

I confirm that removing eggs can't destroy any alien creep anymore. Change introduced makes all alien buildables alive if the overmind is alive, an…

@DolceTriade
Oct 24, 2017

Tooltip is hard because the scoreboard doesn't get any input from the game. It is "view only", like the rest of the HUD. We could make the scoreboa…

@DolceTriade
Oct 24, 2017

I haven't tested to confirm whether this is accurate for aliens.

@slipher
Oct 24, 2017

I still don't see more than 2-3 snowflakes at any given time.

Unvanquished
Unvanquished
Monday, 23 October 2017
@lamefun
Oct 23, 2017

I think the spiker should always shoot and withhold only the spikes that have a high chance of killing or seriously damaging friendly structures. I…

@Kangz
Oct 23, 2017

I don't think it has been fixed.

@illwieckz
Oct 23, 2017

The issue is in a third party-product, hence closing this issue as CANTFIX.

@illwieckz
Oct 23, 2017
Google Chrome silently invalidates Unvanquished security fixes #996

See: https://bugs.chromium.org/p/chromium/issues/detail?id=479419#c10 Chromes silently rewrites version strings from our packages, rewriting tilde

6 comments
@illwieckz
Oct 23, 2017

See DaemonEngine/Daemon#43Redesign key bind handling, to support Unicode among other things” on engine side.

@illwieckz
Oct 23, 2017

what's the status on this?

@illwieckz
Oct 23, 2017

On 0.50.0 I never seen any missing snow issue. I guess we can close?

@illwieckz
Oct 23, 2017

The leech model is not anymore used in unvanquished since some releases, is this bug a generic bug revealed by the leech model, or a leech-specif…

@illwieckz
Oct 23, 2017

why not just disable the spiker if it will be ineffective? and marking the zone as unbuildable while building?

@illwieckz
Oct 23, 2017

still true

@illwieckz
Oct 23, 2017

gameplay changes actually in pipe makes this issue obsolete: with these changes unpowered buildables are just unpowered and ineffective, but not de…

@illwieckz
Oct 23, 2017

See #732 from @slipher for a duplicate of this bug on the scoreboard case, he posted this screenshot: Note that if it would be cool to have a hove…

@illwieckz
Oct 23, 2017

This issue is a duplicate of #541libRocket: too long strings displaces table elements”.

@illwieckz
Oct 23, 2017
Long name breaks column alignment in scoreboard #732

A long player name causes the scoreboard's Score, Time, and Ping columns to break alignment, and the rightmost column to be cut off along the edge.…

3 comments
@illwieckz
Oct 23, 2017

Why not doing it that way: When you open the shop, the client tells the server you opened the shop, remember you opened the shop (1 boolean), and …

@illwieckz
Oct 23, 2017

This bug i the same issue than #1031The game does not start if there is no sound card at all”. By the way, even if the Dæmon engine is known to n…

@illwieckz
Oct 23, 2017
unvanquish doesn't play sound & crash if some other app was playing sound when unv was started. #724

Bug exists since unv 0.3xsomething. Platform: Arch Linux 64bit, latest updates. Desktop: xfce4 When some application (no matter if Audacity is play…

4 comments
@slipher
slipher pushed to master in DaemonEngine/Daemon
Oct 23, 2017
@slipher
slipher merged a pull request in DaemonEngine/Daemon
Oct 23, 2017
Fix iterator bug #45

This bug I found a few days ago looks like it could be the cause of Unvanquished #1035.

+11 -7
@slipher
slipher pushed to for-0.51.0 in DaemonEngine/Daemon
Oct 23, 2017
@slipher
slipher merged a pull request in DaemonEngine/Daemon
Oct 23, 2017
Keys cleanup #47

The first 3 commits in #43 already were only cleanup so might as well merge them first.

+42 -53
Daemon Engine
Daemon Engine
Sunday, 22 October 2017
@slipher
slipher opened a pull request in DaemonEngine/Daemon
Oct 22, 2017
Keys cleanup #47

The first 3 commits in #43 already were only cleanup so might as well merge them first.

+42 -53
@slipher
slipher opened a pull request in DaemonEngine/Daemon
Oct 22, 2017
Make the use of subject-specific loggers automatic. #46

Instead of doing Logger fooLogger("foo"); ... fooLogger.Notice(...); this allows us to set up the foo logger once, and then simply use Log::Notice(…

+411 -254
@slipher
slipher opened a pull request in DaemonEngine/Daemon
Oct 22, 2017
Fix iterator bug #45

This bug I found a few days ago looks like it could be the cause of Unvanquished #1035.

+11 -7
@illwieckz
Oct 22, 2017

Well, trace above was a bit short. This is the complete trace.

@illwieckz
Oct 22, 2017
client crash while server loads nextmap on newgoon+bsuit3 branch #1035

While running my devgames++ branch, client experiences crashes, likely on map change. Crashes started to occur after having merged bsuit3 branch ab…

Unvanquished
Unvanquished
Friday, 20 October 2017
@illwieckz
illwieckz pushed to master in Unvanquished/pluto-devfeeds
Oct 20, 2017
@illwieckz
illwieckz pushed to master in Unvanquished/pluto-devfeeds
  • @illwieckz 1dde3bc
    do not cut out subtitle, move avatar i bit nstead
Oct 20, 2017
@illwieckz
illwieckz pushed to master in Unvanquished/pluto-devfeeds
Oct 20, 2017
@illwieckz
illwieckz pushed to master in Unvanquished/pluto-devfeeds
  • @illwieckz 06be022
    improve style, gitlab compatibility
Oct 20, 2017
@illwieckz
illwieckz pushed to master in Unvanquished/pluto-devfeeds
Oct 20, 2017
Unvanquished
Unvanquished
Thursday, 19 October 2017
@illwieckz
Oct 19, 2017

iirc, with new gameplay changes, the repeater is not needed anymore, drill both mines bp and provides bp for its area. So we have to remove a bubbl…

@illwieckz
Oct 19, 2017

I have to triple-check it but it looks like goon eyes are not rendered correctly (it's so subtle that if we release it as is a very few will notice…

Unvanquished
Unvanquished
Wednesday, 18 October 2017
@illwieckz
Oct 18, 2017

Note that these two lines: Warn: blocker Warn: not blocker->oldEnt are printed 60 times before each Warn: Spawn blocking entity has oldEnt == nullptr

@illwieckz
Oct 18, 2017

Well, I get this warn. I did that (above your own changes): if (blocker) { + logger.Warn("blocker"); if (!blocker->oldEnt) { + logger.Warn("not bl…

@illwieckz
Oct 18, 2017

When crashing, the backtrace looks to be all about thinking component: Thread 29 "daemon" received signal SIGSEGV, Segmentation fault. [Switching t…

@slipher
Oct 18, 2017

Are you getting the log message with Spawn blocking entity has oldEnt == nullptr? If not, the change is not actually doing anything.

@illwieckz
Oct 18, 2017

@slipher's change is fixing the issue on my end.

@DolceTriade
Oct 18, 2017

Goon needs to be made bigger.

@illwieckz
illwieckz pushed to master in Unvanquished/pluto-devfeeds
  • @illwieckz e5559bd
    fix little mistake in planet.ini path
Oct 18, 2017
@illwieckz
illwieckz pushed to master in Unvanquished/pluto-devfeeds
  • @illwieckz 8cae85c
    add pluto.ini file and Makefile, edit README
Oct 18, 2017
Unvanquished
Unvanquished
Tuesday, 17 October 2017
@illwieckz
illwieckz pushed to master in Unvanquished/pluto-devfeeds
  • @illwieckz df3a3e2
    add pluto.ini file and Makefile, edit README
Oct 17, 2017
@illwieckz
illwieckz pushed to master in Unvanquished/pluto-devfeeds
Oct 17, 2017
@DolceTriade
DolceTriade pushed to master in Unvanquished/breakpad-webui
  • @DolceTriade 067917b
    app: Write hacky flask app to render crash dumps
Oct 17, 2017
@DolceTriade
DolceTriade commented on pull request Unvanquished/Unvanquished#1026
Oct 17, 2017

We should make macros for this. LOG_EVERY_INTERVAL() and have another variant LOG_EVERY_N(). Having this type of thing is super ugly for logs every…

@illwieckz
illwieckz commented on issue DaemonEngine/Daemon#34
Oct 17, 2017

It's very easy to reproduce it with a goon in plat23's outside too.

Unvanquished
Unvanquished
Monday, 16 October 2017
@slipher
slipher commented on pull request Unvanquished/Unvanquished#1026
Oct 16, 2017

Added logging if the think component isn't called the expected number of times.

@illwieckz
illwieckz pushed to master in Unvanquished/Unvanquished
Oct 16, 2017
@illwieckz
illwieckz merged a pull request in Unvanquished/Unvanquished
Oct 16, 2017
call OnMapRestart on MapRestart, ref #986 #1034

It looks like OnMapRestart is expected to be called on MapRestart.

+2 -0
1 comment
@illwieckz
illwieckz pushed to master in Unvanquished/Unvanquished
  • @illwieckz c7fea08
    Merge pull request #1033 from illwieckz/botui
  • @illwieckz 2781f0f
    add a missing # to UNNAMED_PLAYER prefix for when g_unnamedNamePrefix…
  • 1 more commit »
Oct 16, 2017
@illwieckz
Oct 16, 2017
bot add by GUI does not use defined bot name #765

Hi, if we add bot with Add an alien bot or Add an human bot menu entries, the bot created uses the default names (Lavishment and Pulsifer), not the…

@illwieckz
illwieckz merged a pull request in Unvanquished/Unvanquished
Oct 16, 2017
do not hardcode bot names in ui rml, allow ui to reuse user defined botnames, fix #765 #1033

do not hardcode bot names in ui rml allow ui to reuse user defined botnames set default bot names in G_BotInit()

+3 -3
3 comments
@DolceTriade
Oct 16, 2017

This will need to be a librocket fix.

@illwieckz
illwieckz commented on pull request Unvanquished/Unvanquished#1033
Oct 16, 2017

Doing Bot#1 means duplicating a lot of code for prefix handling and padding computation. So it's a good idea but I don't want to include this withi…

@illwieckz
Oct 16, 2017

I tried to add many "overflow: hidden" styles in many places but have not yet managed to solve it. :-/

@illwieckz
illwieckz commented on pull request Unvanquished/Unvanquished#1033
Oct 16, 2017

I removed the code that was hardcoding default name. We can do that in another PR (adding a default list, generating a random one, setting a per-bo…

@DolceTriade
DolceTriade commented on pull request Unvanquished/Unvanquished#1033
Oct 16, 2017

I don't think we have one. We don't have a script that runs by default. We could modify the code here https://github.com/Unvanquished/Unvanquished/…

@illwieckz
illwieckz commented on pull request Unvanquished/Unvanquished#1033
Oct 16, 2017

btw, to answer the question, I think it would be overkill, or at least out of focus of this PR (same if we want to add the ability to set default b…

@DolceTriade
DolceTriade commented on pull request Unvanquished/Unvanquished#1033
Oct 16, 2017

I think this is acceptable honestly. We could also make a default set.

@illwieckz
illwieckz commented on pull request Unvanquished/Unvanquished#1033
Oct 16, 2017

Well perhaps we just have to put that missing # where UNNAMED_PLAYER is defined in daemon instead of adding it to prefix anytime we need the prefix…

@illwieckz
illwieckz commented on pull request Unvanquished/Unvanquished#1033
Oct 16, 2017

We can also name unnamed bots as Bot#1 etc.

@illwieckz
illwieckz commented on pull request Unvanquished/Unvanquished#1033
Oct 16, 2017

I added a commit to fix a very rare bug when g_unnamedNamePrefix is empty, so the prefix used for unnamed players is the same when g_unnamedNamePrefix

@illwieckz
illwieckz commented on pull request Unvanquished/Unvanquished#1033
Oct 16, 2017

We can also not define default bot names at all, server owners will do it by the way.

@illwieckz
illwieckz commented on pull request Unvanquished/Unvanquished#1033
Oct 16, 2017

Where is the best place to do that? Or is there another way (like a default config file shipped with the game)?

@illwieckz
illwieckz commented on pull request Unvanquished/Unvanquished#1034
Oct 16, 2017

Note that CG_OnMapRestart() was called explicitly on restart console command, but not when the map was restarted because there was no map rotation …

@illwieckz
illwieckz opened a pull request in Unvanquished/Unvanquished
Oct 16, 2017
call OnMapRestart on MapRestart, ref #986 #1034

It looks like OnMapRestart is expected to be called on MapRestart.

+2 -0
@DolceTriade
DolceTriade commented on pull request Unvanquished/Unvanquished#1033
Oct 16, 2017

This might be overkill, but what about using lua to generate random bot names? Otherwise, just this change is sufficient to give the bots unique na…

@DolceTriade
DolceTriade commented on pull request Unvanquished/Unvanquished#1033
Oct 16, 2017

I don't think we should hard code names here.

@illwieckz
Oct 16, 2017

Other persisting UI elements: Buildable/Weapons/Evolve forms that were locked when the menu was opened, but then unlocked while the menu was still…